GEM-Remotes/GemBluetoothEmbeddedDevice
2
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

More consistent bluetooth notify

Browse Source
This commit is contained in:
Dave
2024-08-24 11:45:09 -04:00
parent 1c7a10c330
commit 5772ae2ed6
6 changed files with 36 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gem-remotes-esp32/sdkconfig.defaults
View File

@ -27,6 +27,6 @@ CONFIG_BT_NIMBLE_NVS_PERSIST=y
# Change this to set log levels for the esp_idf; but unfortunately also the maximum for cargo.toml.
# Changing maximum level does not seem to accomplish anything despite this commit https://github.com/esp-rs/esp-idf-svc/commit/c76720402b3dc32cc42aec7c2feb4539cc7d2af9
# The unfortunate side effect of this is a 2k larger binary and log spam on startup.
# TODO: revisit and remove this for release?
# TODO DEBUG: revisit and remove this for release?
CONFIG_LOG_DEFAULT_LEVEL_VERBOSE=y
CONFIG_LOG_MAXIMUM_LEVEL_VERBOSE=y

37
gem-remotes-esp32/src/ble_server.rs
View File

@ -14,9 +14,6 @@ const BLE_MAX_INTERVAL: u16 = 48; // x 1.25ms
const BLE_LATENCY: u16 = 0; // Number of packets that can be missed, extending interval
const BLE_TIMEOUT: u16 = 500; // x10ms
const BUTTON_PRESSED: [u8; 1] = [0x1];
const BUTTON_RELEASED: [u8; 1] = [0x0];
const DEVICE_NAME: &str = "Gem Remotes";
const UUID_SERVICE_PAIR: BleUuid = uuid128!("9966ad5a-f13c-4b61-ba66-0861e08d09b4");
@ -34,14 +31,9 @@ pub struct BleServer {
impl BleServer {
pub fn new(dp: &mut Dispatch) -> Self {
let cmds = vec![
// Switch to getting and updating notices; use the command version for sending commands only.
//Commands::BluetoothUp { data: 0 },
//Commands::BluetoothDown { data: 0 },
//Commands::BluetoothStop { data: 0 },
Commands::NotifyMotorDown,
Commands::NotifyMotorStopping,
Commands::NotifyMotorUp,
Commands::NotifyMotorStopped,
Commands::NotifyMotorDown { data: 0 },
Commands::NotifyMotorStop { data: 0 },
Commands::NotifyMotorUp { data: 0 },
];
let r = dp.get_callback_channel(&cmds);
let s = dp.get_cmd_channel();
@ -110,25 +102,14 @@ impl BleServer {
trace!("Received update to bluetooth variable {:?}", cmd);
match cmd {
// TODO DISCUSS: This logic (if one button is pressed others are released) could be done in app instead.
Commands::NotifyMotorUp => {
button_up.lock().set_value(&BUTTON_PRESSED).notify();
button_down.lock().set_value(&BUTTON_RELEASED).notify();
button_stop.lock().set_value(&BUTTON_RELEASED).notify();
Commands::NotifyMotorUp{data} => {
button_up.lock().set_value(&[data]).notify();
}
Commands::NotifyMotorDown => {
button_up.lock().set_value(&BUTTON_RELEASED).notify();
button_down.lock().set_value(&BUTTON_PRESSED).notify();
button_stop.lock().set_value(&BUTTON_RELEASED).notify();
Commands::NotifyMotorDown{data} => {
button_down.lock().set_value(&[data]).notify();
}
Commands::NotifyMotorStopping => {
button_up.lock().set_value(&BUTTON_RELEASED).notify();
button_down.lock().set_value(&BUTTON_RELEASED).notify();
button_stop.lock().set_value(&BUTTON_PRESSED).notify();
}
Commands::NotifyMotorStopped => {
button_up.lock().set_value(&BUTTON_RELEASED).notify();
button_down.lock().set_value(&BUTTON_RELEASED).notify();
button_stop.lock().set_value(&BUTTON_RELEASED).notify();
Commands::NotifyMotorStop{data} => {
button_up.lock().set_value(&[data]).notify();
}
_ => {
error!("Invalid command received by bluetooth handler {:?}", cmd);

15
gem-remotes-esp32/src/commands.rs
View File

@ -24,10 +24,17 @@ pub enum Commands {
ButtonTimerRestart,
ButtonTimerClear,
NotifyMotorUp,
NotifyMotorDown,
NotifyMotorStopping,
NotifyMotorStopped, // Signaled after stop timeout
NotifyMotorUp {data: u8},
NotifyMotorDown {data: u8},
NotifyMotorStop {data: u8},
}
#[non_exhaustive]
pub struct Button;
impl Button {
pub const PRESSED: u8 = 0x1;
pub const RELEASED: u8 = 0x0;
}
pub type CmdType = std::mem::Discriminant<Commands>;

10
gem-remotes-esp32/src/main.rs
View File

@ -29,9 +29,12 @@ fn main() {
// Do basic initialization
esp_idf_svc::sys::link_patches();
esp_idf_svc::log::EspLogger::initialize_default();
// Set log level based on compiler flags
#[cfg(debug_assertions)]
log::set_max_level(log::LevelFilter::Trace);
//TODO DEBUG: remove trace logging
//log::set_max_level(log::LevelFilter::Info);
#[cfg(not(debug_assertions))]
log::set_max_level(log::LevelFilter::Info);
// Set panic to use error! instead of write! (as we will potentially log errors)
panic::set_hook(Box::new(|panic_info| {
@ -49,6 +52,7 @@ fn main() {
error!("A panic occurred at {}:{}: {}", filename, line, cause);
}));
// Start up our main loop
match future::block_on(main_loop()) {
Ok(_) => {error!("Exited main loop with no errors, but this should not happen."); panic!();}
Err(e) => {error!("Exited main loop with error {}", e); panic!();}
@ -62,7 +66,7 @@ async fn main_loop() -> Result<()> {
let mut dp = dispatch::Dispatch::new();
// Debug Drivers (TODO DEBUG: remove debug)
let motor_driver = motor_driver::MotorDriverDebug::new(dp.get_cmd_channel());
let motor_driver = motor_driver::MotorDriverDebug::new();
// Setup of various drivers that need to out-live the executor
let m_chan = motor_controller::Controller::prepare_controller(&mut dp);

9
gem-remotes-esp32/src/motor_controller.rs
View File

@ -5,7 +5,7 @@ use log::*; //{trace, debug, info, warn, error}
//use async_channel::Receiver;
use anyhow::Result;
use crate::commands::Commands;
use crate::commands::{Commands, Button};
use crate::motor_driver::Commands as MotorCommands;
use crate::motor_driver::SendQ as MotorSendQ;
use crate::dispatch::{Dispatch, RecvQ, SendQ};
@ -55,19 +55,22 @@ impl Controller {
match new_s {
ControllerStates::Stopped => {
// Other notify commands are sent directly from the motor controller
self.send.send(Commands::NotifyMotorStopped).await?;
self.send.send(Commands::NotifyMotorStop{data: Button::RELEASED}).await?;
}
ControllerStates::Stopping => {
self.send.send(Commands::StopTimerRestart).await?;
self.motor_q.send(MotorCommands::Stop).await?;
self.send.send(Commands::NotifyMotorStop{data: Button::PRESSED}).await?;
}
ControllerStates::GoingUp => {
self.send.send(Commands::ButtonTimerRestart).await?;
self.motor_q.send(MotorCommands::StartUp).await?;
self.send.send(Commands::NotifyMotorUp{data: Button::PRESSED}).await?;
}
ControllerStates::GoingDown => {
self.send.send(Commands::ButtonTimerRestart).await?;
self.motor_q.send(MotorCommands::StartDown).await?;
self.send.send(Commands::NotifyMotorUp{data: Button::PRESSED}).await?;
}
}
Ok(())
@ -92,9 +95,11 @@ impl Controller {
}
ControllerStates::GoingUp => {
self.send.send(Commands::ButtonTimerClear).await?;
self.send.send(Commands::NotifyMotorUp{data: Button::RELEASED}).await?;
}
ControllerStates::GoingDown => {
self.send.send(Commands::ButtonTimerClear).await?;
self.send.send(Commands::NotifyMotorDown{data: Button::RELEASED}).await?;
}
}
Ok(())

10
gem-remotes-esp32/src/motor_driver.rs
View File

@ -4,9 +4,6 @@ use log::*; //{trace, debug, info, warn, error}
use anyhow::Result;
use async_channel::{unbounded, Receiver, Sender};
use crate::dispatch;
use crate::commands::Commands as Dispatch_Commands;
#[derive(Clone, Copy, Debug)]
pub enum Commands {
StartUp,
@ -20,17 +17,15 @@ pub type RecvQ = Receiver<Commands>;
pub struct MotorDriverDebug{
endpoint: SendQ,
recv_q: RecvQ,
dispatch: dispatch::SendQ,
}
/// Debug / example version of Motor Driver.
impl MotorDriverDebug {
pub fn new(send_q: dispatch::SendQ) -> Self {
pub fn new() -> Self {
let (s,r) = unbounded();
MotorDriverDebug {
endpoint: s,
recv_q: r,
dispatch:send_q
}
}
@ -56,17 +51,14 @@ impl MotorDriverDebug {
pub async fn start_up(&self) -> Result<()> {
warn!("Starting motor, direction: Up");
self.dispatch.send(Dispatch_Commands::NotifyMotorUp).await?;
Ok(())
}
pub async fn start_down(&self) -> Result<()> {
warn!("Starting motor, direction: Down");
self.dispatch.send(Dispatch_Commands::NotifyMotorDown).await?;
Ok(())
}
pub async fn stop(&self) -> Result<()> {
warn!("Stopping motor");
self.dispatch.send(Dispatch_Commands::NotifyMotorStopping).await?;
Ok(())
}
}